Chore/ci workflows #193

abbesBenayache · 2025-07-10T08:26:56Z

No description provided.

SeddikBellamine

Good work, overall we need to make some changes left you some comments to reconsider

.github/workflows/conventional-commit-check-pr-title.yml

.github/workflows/dapp-deploy.yml

.github/workflows/reusable-npm.yml

SeddikBellamine · 2025-07-15T09:09:34Z

.release-please-manifest.json

@@ -0,0 +1,10 @@
+{
+  "packages": {


for some reason the actual version of release please dosn't support multiple packages, and it goes like this to make it work:
{ ".": "1.2.2" }

deployment-dapp/src/config/config.ts

SeddikBellamine · 2025-07-15T09:12:43Z

deployment-dapp/src/config/config.ts

  readFileSync('../dapp/package.json', 'utf-8')
 ).version;

 export const DOCKER_IMAGE_NAMESPACE = 'iexechub';


we won't need the SCONIFIER_VERSION and dappVersion as we are using input tag from env variable

SeddikBellamine · 2025-07-15T09:14:23Z

release-please-config.json

+      "changelog-path": "CHANGELOG.md",
+      "include-v-in-tag": true
+    },
+    "dapp": {


multiple packages dosn't work we need to investigate plus

PierreJeanjacquot · 2025-07-16T07:25:44Z

.github/workflows/dapp-deploy.yml

+env:
+  DEPLOY_ENVIRONMENT: ${{ inputs.environment }}


can't find where this env is consumed

PierreJeanjacquot · 2025-07-16T07:28:19Z

.github/workflows/dapp-deploy.yml

+          DOCKER_IMAGE_DEV_TAG: ${{ env.DOCKER_IMAGE_DEV_TAG }}
+          DOCKER_IMAGE_PROD_TAG: ${{ env.DOCKER_IMAGE_PROD_TAG }}


these two seems to be empty

PierreJeanjacquot · 2025-07-16T08:00:38Z

.github/workflows/dapp-deploy.yml

we may want to refactor using enviroments secrets instead of dev/prod in en names https://docs.github.com/en/actions/how-tos/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-an-environment

- Remove .drone.yml configuration - Add GitHub Actions workflows for CI/CD - Update .gitignore for GitHub Actions artifacts - Add workflows for SDK and Dapp CI/CD pipelines

- Add release-please configuration for automated versioning - Add release manifest for tracking version changes - Enable conventional commit checks for PR titles and commits

- Migrate deployment scripts from Drone to GitHub Actions environment variables - Update configuration to support multi-environment deployments - Improve environment-specific whitelisted apps configuration - Update deployment scripts for new workflow compatibility

- Update test utilities for new environment configuration - Update environment preparation scripts for multi-env support - Update dapp e2e tests for new environment configuration - Improve test environment setup for CI/CD workflows

…to secrets

…order steps and use only dev tag

SeddikBellamine

LGTM

abbesBenayache requested a review from SeddikBellamine July 10, 2025 09:41

SeddikBellamine suggested changes Jul 15, 2025

View reviewed changes

PierreJeanjacquot self-requested a review July 15, 2025 10:20

PierreJeanjacquot reviewed Jul 16, 2025

View reviewed changes

chore(dapp): upgrade to node 20

2906edf

abbesBenayache had a problem deploying to bellecour-dev July 17, 2025 19:41 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 17, 2025 20:17 — with GitHub Actions Failure

abbesBenayache force-pushed the chore/ci-workflows branch from c28d528 to aa2733e Compare July 17, 2025 20:44

abbesBenayache temporarily deployed to bellecour-dev July 17, 2025 20:45 — with GitHub Actions Inactive

abbesBenayache temporarily deployed to bellecour-dev July 17, 2025 20:54 — with GitHub Actions Inactive

abbesBenayache temporarily deployed to bellecour-dev July 17, 2025 21:01 — with GitHub Actions Inactive

abbesBenayache had a problem deploying to bellecour-dev July 17, 2025 21:15 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 17, 2025 21:50 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 17, 2025 22:22 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 17, 2025 22:46 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 18, 2025 09:49 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 18, 2025 10:10 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 18, 2025 10:29 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 18, 2025 12:48 — with GitHub Actions Failure

abbesBenayache had a problem deploying to bellecour-dev July 18, 2025 13:02 — with GitHub Actions Failure

abbesBenayache added 5 commits July 18, 2025 15:19

feat(ci): migrate from Drone to GitHub Actions

19710ab

- Remove .drone.yml configuration - Add GitHub Actions workflows for CI/CD - Update .gitignore for GitHub Actions artifacts - Add workflows for SDK and Dapp CI/CD pipelines

feat(release): configure release-please for automated releases

05d016f

- Add release-please configuration for automated versioning - Add release manifest for tracking version changes - Enable conventional commit checks for PR titles and commits

chore(deps): update package.json for new CI/CD setup

e9d4cf8

abbesBenayache force-pushed the chore/ci-workflows branch from 08de737 to e9d4cf8 Compare July 18, 2025 13:27

abbesBenayache added 2 commits July 18, 2025 15:36

chore(dapp): upgrade to Node.js 20

c2ea9ba

chore(dapp): sync package-lock.json with package.json

27924c6

SeddikBellamine had a problem deploying to arbitrum-sepolia-dev July 18, 2025 13:49 — with GitHub Actions Failure

ci: add bellecour-dev environment and move WEB3MAIL_WHITELISTED_APPS …

6655b28

…to secrets

abbesBenayache temporarily deployed to bellecour-dev July 18, 2025 13:53 — with GitHub Actions Inactive

Update deployment-dapp utils

cddddea

abbesBenayache had a problem deploying to bellecour-dev July 18, 2025 14:19 — with GitHub Actions Failure

chore: format code with prettier

69bcd03

abbesBenayache temporarily deployed to bellecour-dev July 18, 2025 14:21 — with GitHub Actions Inactive

SeddikBellamine had a problem deploying to bellecour-dev July 18, 2025 15:03 — with GitHub Actions Error

abbesBenayache had a problem deploying to bellecour-dev July 18, 2025 16:55 — with GitHub Actions Failure

SeddikBellamine had a problem deploying to arbitrum-sepolia-dev July 18, 2025 21:25 — with GitHub Actions Failure

SeddikBellamine had a problem deploying to arbitrum-sepolia-dev July 18, 2025 21:44 — with GitHub Actions Failure

SeddikBellamine had a problem deploying to bellecour-dev July 18, 2025 23:51 — with GitHub Actions Error

SeddikBellamine had a problem deploying to arbitrum-sepolia-dev July 18, 2025 23:55 — with GitHub Actions Failure

SeddikBellamine temporarily deployed to bellecour-dev July 19, 2025 00:00 — with GitHub Actions Inactive

SeddikBellamine had a problem deploying to arbitrum-sepolia-dev July 19, 2025 00:04 — with GitHub Actions Failure

SeddikBellamine force-pushed the chore/ci-workflows branch from 8e0a683 to 69bcd03 Compare July 19, 2025 00:11

SeddikBellamine temporarily deployed to bellecour-dev July 19, 2025 00:11 — with GitHub Actions Inactive

ci: add RPC_URL environment variable to push secret and publish sell …

2993fe4

…order steps and use only dev tag

SeddikBellamine temporarily deployed to bellecour-dev July 19, 2025 00:19 — with GitHub Actions Inactive

SeddikBellamine temporarily deployed to arbitrum-sepolia-dev July 19, 2025 00:28 — with GitHub Actions Inactive

abbesBenayache requested a review from SeddikBellamine July 21, 2025 08:06

chore: temporarily remove bellecour-prod from deployment matrix

0367d29

abbesBenayache temporarily deployed to bellecour-dev July 21, 2025 09:21 — with GitHub Actions Inactive

SeddikBellamine approved these changes Jul 21, 2025

View reviewed changes

abbesBenayache merged commit e028a1c into main Jul 21, 2025
6 of 9 checks passed

abbesBenayache deleted the chore/ci-workflows branch July 21, 2025 20:28

		DOCKER_IMAGE_DEV_TAG: ${{ env.DOCKER_IMAGE_DEV_TAG }}
		DOCKER_IMAGE_PROD_TAG: ${{ env.DOCKER_IMAGE_PROD_TAG }}

Chore/ci workflows #193

Chore/ci workflows #193

Uh oh!

Conversation

abbesBenayache commented Jul 10, 2025

Uh oh!

SeddikBellamine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SeddikBellamine Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SeddikBellamine Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

SeddikBellamine Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

PierreJeanjacquot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

PierreJeanjacquot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

PierreJeanjacquot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

SeddikBellamine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants